Yosemite: Don't show the default placeholder of NSSearchFieldCell.

Source/core/rendering/RenderThemeChromiumMac.mm

Index: Source/core/rendering/RenderThemeChromiumMac.mm
diff --git a/Source/core/rendering/RenderThemeChromiumMac.mm b/Source/core/rendering/RenderThemeChromiumMac.mm
index 920251ec9e6af5d2ce52c90ff1ae2412eebe7dd5..8cd2b9e21ab60b3b2e1a836b427a5b9ea4a0d488 100644
--- a/Source/core/rendering/RenderThemeChromiumMac.mm
+++ b/Source/core/rendering/RenderThemeChromiumMac.mm
@@ -1667,6 +1667,16 @@ NSSearchFieldCell* RenderThemeChromiumMac::search() const
         [m_search.get() setBezeled:YES];
         [m_search.get() setEditable:YES];
         [m_search.get() setFocusRingType:NSFocusRingTypeExterior];
+        SEL sel = @selector(setCenteredLook:);
+        if ([m_search.get() respondsToSelector:sel]) {
+            BOOL boolValue = NO;
+            NSMethodSignature* signature = [NSSearchFieldCell instanceMethodSignatureForSelector:sel];
+            NSInvocation* invocation = [NSInvocation invocationWithMethodSignature: signature];

[keishi, 2014/09/22 06:13:05]

I think you should be able to do

NSNumber *boolValue = [NSNumber numberWithBool:NO];
[m_search.get() performSelector:SEL withObject:boolValue];

[tkent, 2014/09/22 08:00:34]

I confirmed it didn't work.  It threw no exception, but looked no effect.

[keishi, 2014/09/22 08:56:58]

Strange.

[Robert Sesek, 2014/09/22 14:42:49]

Right, this shouldn't work because one NSNumber is an object and this method is
accepting a BOOL literal -- they are not the same thing.

[Robert Sesek, 2014/09/22 14:42:49]

nit: no space after :

[Robert Sesek, 2014/09/22 20:58:31]

You didn't address this comment.

[tkent, 2014/09/23 22:39:10]

Oops, I overlooked the comment.  Will address it in another CL.

+            [invocation setTarget:m_search.get()];
+            [invocation setSelector:sel];
+            [invocation setArgument:&boolValue atIndex:2];
+            [invocation invoke];
+        }
     }
 
     return m_search.get();