Yosemite: Don't show the default placeholder of NSSearchFieldCell.

Source/core/rendering/RenderThemeChromiumMac.mm

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 1649 matching lines @@
 }
 
 NSSearchFieldCell* RenderThemeChromiumMac::search() const
 {
     if (!m_search) {
         m_search.adoptNS([[NSSearchFieldCell alloc] initTextCell:@""]);
         [m_search.get() setBezelStyle:NSTextFieldRoundedBezel];
         [m_search.get() setBezeled:YES];
         [m_search.get() setEditable:YES];
         [m_search.get() setFocusRingType:NSFocusRingTypeExterior];
+        SEL sel = @selector(setCenteredLook:);
+        if ([m_search.get() respondsToSelector:sel]) {
+            BOOL boolValue = NO;
+            NSMethodSignature* signature = [NSSearchFieldCell instanceMethodSignatureForSelector:sel];
+            NSInvocation* invocation = [NSInvocation invocationWithMethodSignature: signature];

[keishi, 2014/09/22 06:13:05]

I think you should be able to do

NSNumber *boolValue = [NSNumber numberWithBool:NO];
[m_search.get() performSelector:SEL withObject:boolValue];

[tkent, 2014/09/22 08:00:34]

I confirmed it didn't work.  It threw no exception, but looked no effect.

[keishi, 2014/09/22 08:56:58]

Strange.

[Robert Sesek, 2014/09/22 14:42:49]

Right, this shouldn't work because one NSNumber is an object and this method is
accepting a BOOL literal -- they are not the same thing.

[Robert Sesek, 2014/09/22 14:42:49]

nit: no space after :

[Robert Sesek, 2014/09/22 20:58:31]

You didn't address this comment.

[tkent, 2014/09/23 22:39:10]

Oops, I overlooked the comment.  Will address it in another CL.

+            [invocation setTarget:m_search.get()];
+            [invocation setSelector:sel];
+            [invocation setArgument:&boolValue atIndex:2];
+            [invocation invoke];
+        }
     }
 
     return m_search.get();
 }
 
 NSMenu* RenderThemeChromiumMac::searchMenuTemplate() const
 {
     if (!m_searchMenuTemplate)
         m_searchMenuTemplate.adoptNS([[NSMenu alloc] initWithTitle:@""]);
 
@@ skipping 175 matching lines @@
 
 bool RenderThemeChromiumMac::shouldUseFallbackTheme(RenderStyle* style) const
 {
     ControlPart part = style->appearance();
     if (part == CheckboxPart || part == RadioPart)
         return style->effectiveZoom() != 1;
     return false;
 }
 
 } // namespace blink