Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 581663003: Remove more stuff from applyAuthorStyles. (Closed)

Created:
6 years, 3 months ago by esprehn
Modified:
6 years, 3 months ago
Reviewers:
dglazkov, kochi, ojan
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof
Project:
blink
Visibility:
Public.

Description

Remove more stuff from applyAuthorStyles. There's a lot of machinery that's realted to <style scoped> and applyAuthorStyles that's now dead and is just making things slower. Lets remove it all. BUG=372083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -44 lines) Patch
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/MatchRequest.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 5 chunks +5 lines, -14 lines 0 comments Download
M Source/core/dom/TreeScope.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
6 years, 3 months ago (2014-09-18 23:01:44 UTC) #2
kochi
w00t lgtm I tried this some time ago and for some reason it has been ...
6 years, 3 months ago (2014-09-19 01:22:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/581663003/1
6 years, 3 months ago (2014-09-19 01:28:59 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 01:34:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182291

Powered by Google App Engine
This is Rietveld 408576698