Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3067)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/animation/layer_animation_value_provider.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blow up the patchset :( Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/animation/layer_animation_value_observer.h ('K') | « cc/animation/layer_animation_value_observer.h ('k') | cc/animation/scroll_offset_animation_curve.h » ('j') | cc/input/layer_scroll_offset_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/layer_animation_value_provider.h
diff --git a/cc/animation/layer_animation_value_provider.h b/cc/animation/layer_animation_value_provider.h
index c81496883ed1f1cc019b65fe7e60ceda404b80c2..98032184d3b129edbd0ee555bcea129263919e2e 100644
--- a/cc/animation/layer_animation_value_provider.h
+++ b/cc/animation/layer_animation_value_provider.h
@@ -6,7 +6,7 @@
#define CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_
#include "cc/base/cc_export.h"
-#include "ui/gfx/vector2d_f.h"
+#include "ui/gfx/geometry/scroll_offset.h"
danakj 2014/09/27 00:00:43 can you forward declare it instead?
Yufeng Shen (Slow to review) 2014/09/29 19:27:33 Done.
namespace cc {
@@ -17,7 +17,7 @@ class CC_EXPORT LayerAnimationValueProvider {
public:
virtual ~LayerAnimationValueProvider() {}
- virtual gfx::Vector2dF ScrollOffsetForAnimation() const = 0;
+ virtual gfx::ScrollOffset ScrollOffsetForAnimation() const = 0;
};
} // namespace cc
« cc/animation/layer_animation_value_observer.h ('K') | « cc/animation/layer_animation_value_observer.h ('k') | cc/animation/scroll_offset_animation_curve.h » ('j') | cc/input/layer_scroll_offset_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698