cc/animation/layer_animation_value_provider.h - Issue 584503005: Make scroll offset type of float in cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/animation/layer_animation_value_provider.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: blow up the patchset :( Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/animation/layer_animation_value_observer.h ('K') | « cc/animation/layer_animation_value_observer.h ('k') | cc/animation/scroll_offset_animation_curve.h » ('j') | cc/input/layer_scroll_offset_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_	5 #ifndef CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_

6 #define CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_	6 #define CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_

7	7

8 #include "cc/base/cc_export.h"	8 #include "cc/base/cc_export.h"

9 #include "ui/gfx/vector2d_f.h"	9 #include "ui/gfx/geometry/scroll_offset.h"
	danakj 2014/09/27 00:00:43 can you forward declare it instead? can you forward declare it instead? Yufeng Shen (Slow to review) 2014/09/29 19:27:33 Done. Show quoted text On 2014/09/27 00:00:43, danakj wrote: > can you forward declare it instead? Done.
10	10

11 namespace cc {	11 namespace cc {

12	12

13 // A LayerAnimationValueProvider is used for determining the starting value	13 // A LayerAnimationValueProvider is used for determining the starting value

14 // for animations that start at their 'current' value rather than at a	14 // for animations that start at their 'current' value rather than at a

15 // pre-specified value.	15 // pre-specified value.

16 class CC_EXPORT LayerAnimationValueProvider {	16 class CC_EXPORT LayerAnimationValueProvider {

17 public:	17 public:

18 virtual ~LayerAnimationValueProvider() {}	18 virtual ~LayerAnimationValueProvider() {}

19	19

20 virtual gfx::Vector2dF ScrollOffsetForAnimation() const = 0;	20 virtual gfx::ScrollOffset ScrollOffsetForAnimation() const = 0;

21 };	21 };

22	22

23 } // namespace cc	23 } // namespace cc

24	24

25 #endif // CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_	25 #endif // CC_ANIMATION_LAYER_ANIMATION_VALUE_PROVIDER_H_

OLD	NEW