Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2808)

Unified Diff: cc/animation/layer_animation_value_observer.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blow up the patchset :( Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/animation/layer_animation_value_observer.h
diff --git a/cc/animation/layer_animation_value_observer.h b/cc/animation/layer_animation_value_observer.h
index e09180620f67a0dd4e4ad83b43df1678171547cd..5a5cc63440e2ade199d79d7d9c4c3ce40116ed19 100644
--- a/cc/animation/layer_animation_value_observer.h
+++ b/cc/animation/layer_animation_value_observer.h
@@ -6,6 +6,7 @@
#define CC_ANIMATION_LAYER_ANIMATION_VALUE_OBSERVER_H_
#include "cc/base/cc_export.h"
+#include "ui/gfx/geometry/scroll_offset.h"
danakj 2014/09/27 00:00:43 forward declare it instead
Yufeng Shen (Slow to review) 2014/09/29 19:27:33 Done.
namespace cc {
@@ -16,7 +17,8 @@ class CC_EXPORT LayerAnimationValueObserver {
virtual void OnFilterAnimated(const FilterOperations& filters) = 0;
virtual void OnOpacityAnimated(float opacity) = 0;
virtual void OnTransformAnimated(const gfx::Transform& transform) = 0;
- virtual void OnScrollOffsetAnimated(const gfx::Vector2dF& scroll_offset) = 0;
+ virtual void OnScrollOffsetAnimated(
+ const gfx::ScrollOffset& scroll_offset) = 0;
virtual void OnAnimationWaitingForDeletion() = 0;
virtual bool IsActive() const = 0;
};
@@ -24,4 +26,3 @@ class CC_EXPORT LayerAnimationValueObserver {
} // namespace cc
#endif // CC_ANIMATION_LAYER_ANIMATION_VALUE_OBSERVER_H_
-

Powered by Google App Engine
This is Rietveld 408576698