net/cert/x509_certificate_mac.cc - Issue 584463005: Add debugging information to the SSL blocking page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_mac.cc

Issue 584463005: Add debugging information to the SSL blocking page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a few more checks in x509_certificate_ files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate_mac.cc

diff --git a/net/cert/x509_certificate_mac.cc b/net/cert/x509_certificate_mac.cc

index b3815765265d941dc570d3a324e126f9161c72f1..716bdd5c4ec1ce4ca272b5cf2fb187b6731feeb0 100644

--- a/net/cert/x509_certificate_mac.cc

+++ b/net/cert/x509_certificate_mac.cc

@@ -274,7 +274,7 @@ void X509Certificate::GetSubjectAltName(

bool X509Certificate::GetDEREncoded(X509Certificate::OSCertHandle cert_handle,

std::string* encoded) {

CSSM_DATA der_data;

- if (SecCertificateGetData(cert_handle, &der_data) != noErr)

+ if (!cert_handle || SecCertificateGetData(cert_handle, &der_data) != noErr)

return false;

encoded->assign(reinterpret_cast<char*>(der_data.Data),

der_data.Length);