net/cert/x509_certificate_ios.cc - Issue 584463005: Add debugging information to the SSL blocking page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_ios.cc

Issue 584463005: Add debugging information to the SSL blocking page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a few more checks in x509_certificate_ files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate_ios.cc

diff --git a/net/cert/x509_certificate_ios.cc b/net/cert/x509_certificate_ios.cc

index ee10381953717316f7fc49590645fb0d4d608886..f59cb650993cb039bf64d67f794c7952a5f3e366 100644

--- a/net/cert/x509_certificate_ios.cc

+++ b/net/cert/x509_certificate_ios.cc

@@ -103,6 +103,8 @@ void X509Certificate::GetSubjectAltName(

// static

bool X509Certificate::GetDEREncoded(OSCertHandle cert_handle,

std::string* encoded) {

+ if (!cert_handle)

+ return false;

ScopedCFTypeRef<CFDataRef> der_data(SecCertificateCopyData(cert_handle));

if (!der_data)

return false;