net/cert/x509_certificate_win.cc - Issue 584463005: Add debugging information to the SSL blocking page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_win.cc

Issue 584463005: Add debugging information to the SSL blocking page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a few more checks in x509_certificate_ files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate_win.cc

diff --git a/net/cert/x509_certificate_win.cc b/net/cert/x509_certificate_win.cc

index c679107371a8594e8202b725bf4078d46f7b8074..3aa576321e8bc168ce5260fd552e008cb45786c0 100644

--- a/net/cert/x509_certificate_win.cc

+++ b/net/cert/x509_certificate_win.cc

@@ -235,7 +235,8 @@ PCCERT_CONTEXT X509Certificate::CreateOSCertChainForCert() const {

// static

bool X509Certificate::GetDEREncoded(X509Certificate::OSCertHandle cert_handle,

std::string* encoded) {

- if (!cert_handle->pbCertEncoded || !cert_handle->cbCertEncoded)

+ if (!cert_handle || !cert_handle->pbCertEncoded ||

+ !cert_handle->cbCertEncoded)

agl 2014/09/23 20:30:00 this needs { } now that it's a multi-line conditio

felt 2014/09/24 03:53:48 Done.

return false;

encoded->assign(reinterpret_cast<char*>(cert_handle->pbCertEncoded),

cert_handle->cbCertEncoded);

« no previous file with comments | « net/cert/x509_certificate_openssl.cc ('k') | no next file » | no next file with comments »