Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations

content/browser/frame_host/render_frame_host_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/callback.h"
 #include "base/strings/string16.h"
 #include "content/browser/frame_host/render_frame_host_delegate.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 21 matching lines @@
   return false;
 }
 
 WebContents* RenderFrameHostDelegate::GetAsWebContents() {
   return NULL;
 }
 
 void RenderFrameHostDelegate::RequestMediaAccessPermission(
     const MediaStreamRequest& request,
     const MediaResponseCallback& callback) {
+  NOTREACHED();

[tommi (sloooow) - chröme, 2014/09/20 14:25:38]

I'm not sure about this since there is an implementation here already.

If these methods are not expected to be called, can we skip implementing them
altogether and force subclasses to make this decision (implement vs
NOTREACHED())?

[Henrik Grunell, 2014/09/22 08:49:52]

Yeah, Per and I discussed this before. I had that standpoint at first, then we
kind of came to the conclusion to do it here. Changed.

   callback.Run(MediaStreamDevices(),
                MEDIA_DEVICE_INVALID_STATE,
                scoped_ptr<MediaStreamUI>());
 }
 
 bool RenderFrameHostDelegate::CheckMediaAccessPermission(
     const GURL& security_origin,
     MediaStreamType type) {
-  DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
-         type == MEDIA_DEVICE_VIDEO_CAPTURE);
+  NOTREACHED();
   return false;
 }
 
 AccessibilityMode RenderFrameHostDelegate::GetAccessibilityMode() const {
   return AccessibilityModeOff;
 }
 
 RenderFrameHost* RenderFrameHostDelegate::GetGuestByInstanceID(
     int browser_plugin_instance_id) {
   return NULL;
 }
 
 #if defined(OS_WIN)
 gfx::NativeViewAccessible
     RenderFrameHostDelegate::GetParentNativeViewAccessible() {
   return NULL;
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace content