Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 583963002: [turbofan] IA: Uint32ToFloat64 supports mem operand. (Closed)

Created:
6 years, 3 months ago by Jing
Modified:
6 years, 2 months ago
CC:
v8-dev, Weiliang
Base URL:
https://github.com/v8/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

[turbofan] IA: Uint32ToFloat64 supports mem operand. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24318

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : #

Patch Set 4 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -15 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64-unittest.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jing
6 years, 3 months ago (2014-09-20 16:28:27 UTC) #2
danno
Adding Dan as reviewer
6 years, 3 months ago (2014-09-25 07:44:49 UTC) #4
dcarney
On 2014/09/25 07:44:49, danno wrote: > Adding Dan as reviewer lgtm if you add an ...
6 years, 3 months ago (2014-09-25 07:59:38 UTC) #5
Jing
On 2014/09/25 07:59:38, dcarney wrote: > On 2014/09/25 07:44:49, danno wrote: > > Adding Dan ...
6 years, 2 months ago (2014-09-26 09:01:42 UTC) #6
dcarney
Committed patchset #4 (id:60001) manually as 24318 (presubmit successful).
6 years, 2 months ago (2014-09-30 10:24:27 UTC) #7
dcarney
6 years, 2 months ago (2014-09-30 10:25:11 UTC) #8
Message was sent while issue was closed.
> I added some tests. PTAL.
> Thanks.

Sorry for the delay landing this.  I didn't see your last message.

Powered by Google App Engine
This is Rietveld 408576698