src/compiler/x64/instruction-selector-x64.cc - Issue 583963002: [turbofan] IA: Uint32ToFloat64 supports mem operand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 583963002: [turbofan] IA: Uint32ToFloat64 supports mem operand. (Closed) Base URL: https://github.com/v8/v8.git@bleeding_edge

Patch Set: Add tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-selector-x64.cc

diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc

index 8d41fa1871c906bc21b89ddb2b6762bae9d19f6e..2f8c491ba15c222154fb7743ac883331926a7beb 100644

--- a/src/compiler/x64/instruction-selector-x64.cc

+++ b/src/compiler/x64/instruction-selector-x64.cc

@@ -486,9 +486,7 @@ void InstructionSelector::VisitChangeInt32ToFloat64(Node* node) {

void InstructionSelector::VisitChangeUint32ToFloat64(Node* node) {

X64OperandGenerator g(this);

- // TODO(turbofan): X64 SSE cvtqsi2sd should support operands.

- Emit(kSSEUint32ToFloat64, g.DefineAsRegister(node),

- g.UseRegister(node->InputAt(0)));

+ Emit(kSSEUint32ToFloat64, g.DefineAsRegister(node), g.Use(node->InputAt(0)));

}