Fix WeakPtrFactory member placement

Fix WeakPtrFactory member placement

Changing in the intialization order of WeakPtrFactory.
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/17ad2e4ea855d060b73d8a5f688bba8f066f0b62
Cr-Commit-Position: refs/heads/master@{#298400}

[praveen, 2014-09-18 13:49:12]

praveen.anp@samsung.com changed reviewers:
+ pritam.nikam@samsung.com, vivek.vg@samsung.com

[praveen, 2014-09-18 13:49:13]

PTAL

[Pritam Nikam, 2014-09-18 14:22:56]

On 2014/09/18 13:49:13, praveen wrote:
> PTAL

Hi Praveen,
Looks pretty good to me. Now it's time to find appropriate owners who
can actually review it. :)

[praveen, 2014-09-18 14:44:11]

praveen.anp@samsung.com changed reviewers:
+ sky@chromium.org
- pritam.nikam@samsung.com, vivek.vg@samsung.com

[praveen, 2014-09-18 14:44:11]

PTAL

[praveen, 2014-09-29 09:08:35]

praveen.anp@samsung.com changed reviewers:
+ bauerb@chromium.org, nyquist@chromium.org
- sky@chromium.org

[Bernhard Bauer, 2014-09-29 15:58:30]

https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_...
File chrome/browser/android/most_visited_sites.h (right):

https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_...
chrome/browser/android/most_visited_sites.h:125: enum MostVisitedSource {
If you're fixing ordering anyway: This should be first in the private section.

[nyquist, 2014-09-29 21:52:11]

Since mv_source_ is not initialized in the constructor you don't have to update
the constructor, yay!
Anyway, when you have addressed the comments from bauerb, this lgtm.

[praveen, 2014-09-30 06:32:41]

On 2014/09/29 15:58:30, Bernhard Bauer wrote:
>
https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_...
> File chrome/browser/android/most_visited_sites.h (right):
> 
>
https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_...
> chrome/browser/android/most_visited_sites.h:125: enum MostVisitedSource {
> If you're fixing ordering anyway: This should be first in the private section.

Done

[nyquist, 2014-09-30 06:58:33]

not lgtm

Please sign the CLA before you submit this CL.

You can find links here:
http://www.chromium.org/developers/contributing-code/external-contributor-che...

Update this review when you have done that.

[Bernhard Bauer, 2014-09-30 13:04:16]

https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/m...
File chrome/browser/android/most_visited_sites.h (right):

https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/m...
chrome/browser/android/most_visited_sites.h:64: MostVisitedSource mv_source_;
Sorry, this should stay in its original place. According to the style guide,
type declarations come before method declarations, which come before members.
That means that we'll have to separate these.

[praveen, 2014-09-30 13:56:42]

On 2014/09/30 13:04:16, Bernhard Bauer wrote:
>
https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/m...
> File chrome/browser/android/most_visited_sites.h (right):
> 
>
https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/m...
> chrome/browser/android/most_visited_sites.h:64: MostVisitedSource mv_source_;
> Sorry, this should stay in its original place. According to the style guide,
> type declarations come before method declarations, which come before members.
> That means that we'll have to separate these.

Done

[Bernhard Bauer, 2014-09-30 14:27:24]

LGTM

[praveen, 2014-10-01 05:22:23]

On 2014/09/30 06:58:33, nyquist wrote:
> not lgtm
> 
> Please sign the CLA before you submit this CL.
> 
> You can find links here:
>
http://www.chromium.org/developers/contributing-code/external-contributor-che...
> 
> Update this review when you have done that.

Signing is done.

[praveen, 2014-10-01 09:22:59]

The CQ bit was checked by praveen.anp@samsung.com

[commit-bot: I haz the power, 2014-10-01 09:23:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583623002/40001

[commit-bot: I haz the power, 2014-10-01 09:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 09:23:43]

A disapproval has been posted by following reviewers: nyquist@chromium.org.
Please make sure to get positive review before another CQ attempt.

[nyquist, 2014-10-02 18:44:54]

lgtm

[praveen, 2014-10-07 05:28:35]

The CQ bit was checked by praveen.anp@samsung.com

[commit-bot: I haz the power, 2014-10-07 05:29:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583623002/40001

[commit-bot: I haz the power, 2014-10-07 06:07:53]

Committed patchset #3 (id:40001) as 883bc7717fc6eea493e767fa53affcc195f415b4

[commit-bot: I haz the power, 2014-10-07 06:08:33]

Patchset 3 (id:??) landed as
https://crrev.com/17ad2e4ea855d060b73d8a5f688bba8f066f0b62
Cr-Commit-Position: refs/heads/master@{#298400}