Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 583623002: Fix WeakPtrFactory member placement (Closed)

Created:
6 years, 3 months ago by praveen
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer, nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member placement Changing in the intialization order of WeakPtrFactory. such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/17ad2e4ea855d060b73d8a5f688bba8f066f0b62 Cr-Commit-Position: refs/heads/master@{#298400}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/most_visited_sites.h View 1 2 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (6 generated)
praveen
PTAL
6 years, 3 months ago (2014-09-18 13:49:13 UTC) #2
Pritam Nikam
On 2014/09/18 13:49:13, praveen wrote: > PTAL Hi Praveen, Looks pretty good to me. Now ...
6 years, 3 months ago (2014-09-18 14:22:56 UTC) #3
praveen
PTAL
6 years, 3 months ago (2014-09-18 14:44:11 UTC) #5
praveen
6 years, 2 months ago (2014-09-29 09:08:36 UTC) #7
Bernhard Bauer
https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_visited_sites.h File chrome/browser/android/most_visited_sites.h (right): https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_visited_sites.h#newcode125 chrome/browser/android/most_visited_sites.h:125: enum MostVisitedSource { If you're fixing ordering anyway: This ...
6 years, 2 months ago (2014-09-29 15:58:30 UTC) #8
nyquist
Since mv_source_ is not initialized in the constructor you don't have to update the constructor, ...
6 years, 2 months ago (2014-09-29 21:52:11 UTC) #9
praveen
On 2014/09/29 15:58:30, Bernhard Bauer wrote: > https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_visited_sites.h > File chrome/browser/android/most_visited_sites.h (right): > > https://codereview.chromium.org/583623002/diff/1/chrome/browser/android/most_visited_sites.h#newcode125 ...
6 years, 2 months ago (2014-09-30 06:32:41 UTC) #10
nyquist
not lgtm Please sign the CLA before you submit this CL. You can find links ...
6 years, 2 months ago (2014-09-30 06:58:33 UTC) #11
Bernhard Bauer
https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/most_visited_sites.h File chrome/browser/android/most_visited_sites.h (right): https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/most_visited_sites.h#newcode64 chrome/browser/android/most_visited_sites.h:64: MostVisitedSource mv_source_; Sorry, this should stay in its original ...
6 years, 2 months ago (2014-09-30 13:04:16 UTC) #12
praveen
On 2014/09/30 13:04:16, Bernhard Bauer wrote: > https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/most_visited_sites.h > File chrome/browser/android/most_visited_sites.h (right): > > https://codereview.chromium.org/583623002/diff/20001/chrome/browser/android/most_visited_sites.h#newcode64 ...
6 years, 2 months ago (2014-09-30 13:56:42 UTC) #13
Bernhard Bauer
LGTM
6 years, 2 months ago (2014-09-30 14:27:24 UTC) #14
praveen
On 2014/09/30 06:58:33, nyquist wrote: > not lgtm > > Please sign the CLA before ...
6 years, 2 months ago (2014-10-01 05:22:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583623002/40001
6 years, 2 months ago (2014-10-01 09:23:40 UTC) #17
commit-bot: I haz the power
A disapproval has been posted by following reviewers: nyquist@chromium.org. Please make sure to get positive ...
6 years, 2 months ago (2014-10-01 09:23:43 UTC) #19
nyquist
lgtm
6 years, 2 months ago (2014-10-02 18:44:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583623002/40001
6 years, 2 months ago (2014-10-07 05:29:47 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 883bc7717fc6eea493e767fa53affcc195f415b4
6 years, 2 months ago (2014-10-07 06:07:53 UTC) #23
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 06:08:33 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/17ad2e4ea855d060b73d8a5f688bba8f066f0b62
Cr-Commit-Position: refs/heads/master@{#298400}

Powered by Google App Engine
This is Rietveld 408576698