Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: chrome/browser/android/most_visited_sites.h

Issue 583623002: Fix WeakPtrFactory member placement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/most_visited_sites.h
diff --git a/chrome/browser/android/most_visited_sites.h b/chrome/browser/android/most_visited_sites.h
index 6609846709ecd1798084ea3795525e1fd000880c..3352b3f20c6cabed21eb938f591275640904091a 100644
--- a/chrome/browser/android/most_visited_sites.h
+++ b/chrome/browser/android/most_visited_sites.h
@@ -56,6 +56,12 @@ class MostVisitedSites : public ProfileSyncServiceObserver,
static bool Register(JNIEnv* env);
private:
+ // The source of the Most Visited sites.
+ enum MostVisitedSource {
+ TOP_SITES,
+ SUGGESTIONS_SERVICE
+ };
+
virtual ~MostVisitedSites();
void QueryMostVisitedURLs();
@@ -119,18 +125,13 @@ class MostVisitedSites : public ProfileSyncServiceObserver,
// Copy of the server suggestions (if enabled). Used for logging.
suggestions::SuggestionsProfile server_suggestions_;
- // For callbacks may be run after destruction.
- base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
-
content::NotificationRegistrar registrar_;
- // The source of the Most Visited sites.
- enum MostVisitedSource {
- TOP_SITES,
- SUGGESTIONS_SERVICE
- };
MostVisitedSource mv_source_;
+ // For callbacks may be run after destruction.
+ base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
};
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698