Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/browser/android/most_visited_sites.h

Issue 583623002: Fix WeakPtrFactory member placement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_ 5 #ifndef CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
6 #define CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_ 6 #define CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 int num_local_thumbs_; 112 int num_local_thumbs_;
113 // Number of tiles for which a server thumbnail is provided. 113 // Number of tiles for which a server thumbnail is provided.
114 int num_server_thumbs_; 114 int num_server_thumbs_;
115 // Number of tiles for which no thumbnail is found/specified and a gray tile 115 // Number of tiles for which no thumbnail is found/specified and a gray tile
116 // is used as the main tile. 116 // is used as the main tile.
117 int num_empty_thumbs_; 117 int num_empty_thumbs_;
118 118
119 // Copy of the server suggestions (if enabled). Used for logging. 119 // Copy of the server suggestions (if enabled). Used for logging.
120 suggestions::SuggestionsProfile server_suggestions_; 120 suggestions::SuggestionsProfile server_suggestions_;
121 121
122 // For callbacks may be run after destruction.
123 base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
124
125 content::NotificationRegistrar registrar_; 122 content::NotificationRegistrar registrar_;
126 123
127 // The source of the Most Visited sites. 124 // The source of the Most Visited sites.
128 enum MostVisitedSource { 125 enum MostVisitedSource {
Bernhard Bauer 2014/09/29 15:58:29 If you're fixing ordering anyway: This should be f
129 TOP_SITES, 126 TOP_SITES,
130 SUGGESTIONS_SERVICE 127 SUGGESTIONS_SERVICE
131 }; 128 };
132 MostVisitedSource mv_source_; 129 MostVisitedSource mv_source_;
133 130
131 // For callbacks may be run after destruction.
132 base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
133
134 DISALLOW_COPY_AND_ASSIGN(MostVisitedSites); 134 DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
135 }; 135 };
136 136
137 #endif // CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_ 137 #endif // CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
OLDNEW
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698