ui/views/win/hwnd_message_handler.cc - Issue 583603004: Add CanMinimize to classes that implement WidgetDelegate::CanMaximize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/win/hwnd_message_handler.cc

Issue 583603004: Add CanMinimize to classes that implement WidgetDelegate::CanMaximize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@win_resizable

Patch Set: hwnd_message_handler Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/win/hwnd_message_handler.cc

diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc

index e684178ebcae0799d12161e82107ce45f595194a..c65f67e42bbb51c564593310599bc6314b29f570 100644

--- a/ui/views/win/hwnd_message_handler.cc

+++ b/ui/views/win/hwnd_message_handler.cc

@@ -1493,9 +1493,7 @@ void HWNDMessageHandler::OnInitMenu(HMENU menu) {

EnableMenuItemByCommand(menu, SC_SIZE, delegate_->CanResize() && is_restored);

EnableMenuItemByCommand(menu, SC_MAXIMIZE, delegate_->CanMaximize() &&

!is_fullscreen && !is_maximized);

- // TODO: unfortunately, WidgetDelegate does not declare CanMinimize() and some

- // code depends on this check, see http://crbug.com/341010.

- EnableMenuItemByCommand(menu, SC_MINIMIZE, delegate_->CanMaximize() &&

+ EnableMenuItemByCommand(menu, SC_MINIMIZE, delegate_->CanMinimize() &&

!is_minimized);

if (is_maximized && delegate_->CanResize())

« ash/frame/custom_frame_view_ash.cc ('K') | « ui/views/widget/widget_delegate.cc ('k') | ui/views/win/hwnd_message_handler_delegate.h » ('j') | no next file with comments »