ash/frame/custom_frame_view_ash.cc - Issue 583603004: Add CanMinimize to classes that implement WidgetDelegate::CanMaximize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/frame/custom_frame_view_ash.cc

Issue 583603004: Add CanMinimize to classes that implement WidgetDelegate::CanMaximize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@win_resizable

Patch Set: hwnd_message_handler Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/frame/custom_frame_view_ash.cc

diff --git a/ash/frame/custom_frame_view_ash.cc b/ash/frame/custom_frame_view_ash.cc

index 450015a32a3256d21b24c3845886d9bdcd4755b3..61a77dd3bc406c725fa9378e03dd1dbe1e93ab6b 100644

--- a/ash/frame/custom_frame_view_ash.cc

+++ b/ash/frame/custom_frame_view_ash.cc

@@ -205,7 +205,7 @@ CustomFrameViewAsh::HeaderView::HeaderView(views::Widget* frame)

// Unfortunately, there is no views::WidgetDelegate::CanMinimize(). Assume

// that the window frame can be minimized if it can be maximized.

pkotwicz 2014/09/22 01:09:00 This comment is no longer true

jackhou1 2014/09/22 02:59:47 Done.

FrameCaptionButtonContainerView::MinimizeAllowed minimize_allowed =

- frame_->widget_delegate()->CanMaximize() ?

+ frame_->widget_delegate()->CanMinimize() ?

FrameCaptionButtonContainerView::MINIMIZE_ALLOWED :

FrameCaptionButtonContainerView::MINIMIZE_DISALLOWED;

caption_button_container_ = new FrameCaptionButtonContainerView(frame_,

« no previous file with comments | « ash/frame/caption_buttons/frame_size_button_unittest.cc ('k') | ash/frame/custom_frame_view_ash_unittest.cc » ('j') | no next file with comments »