Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 583593006: Force scavenge in idle notification if we estimate that it will take long. (Closed)

Created:
6 years, 3 months ago by Hannes Payer (out of office)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Force scavenge in idle notification if we estimate that it will take long. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24379

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -57 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 2 3 4 3 chunks +4 lines, -10 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 3 4 5 2 chunks +36 lines, -20 lines 0 comments Download
M src/heap/gc-idle-time-handler-unittest.cc View 1 2 3 4 5 4 chunks +50 lines, -26 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Hannes Payer (out of office)
adding more unit tests...
6 years, 3 months ago (2014-09-18 15:23:13 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc#newcode100 src/heap/gc-idle-time-handler.cc:100: idle_time_in_ms > kMaxFrameRenderingIdleTime) { that is 16 < idle_time_in_ms ...
6 years, 3 months ago (2014-09-18 18:46:29 UTC) #3
ulan
https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/583593006/diff/1/src/heap/gc-idle-time-handler.cc#newcode125 src/heap/gc-idle-time-handler.cc:125: return DoEarlyScavenge(idle_time_in_ms, new_space_size, As discussed offline, we can probably ...
6 years, 3 months ago (2014-09-19 10:47:48 UTC) #4
Hannes Payer (out of office)
This is now way simpler. PTAL
6 years, 2 months ago (2014-09-26 06:41:10 UTC) #5
ulan
Nice, lgtm! https://codereview.chromium.org/583593006/diff/80001/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/583593006/diff/80001/src/heap/gc-idle-time-handler.cc#newcode107 src/heap/gc-idle-time-handler.cc:107: // (1) If the new space is ...
6 years, 2 months ago (2014-09-26 08:12:22 UTC) #6
Hannes Payer (out of office)
Committed patchset #6 (id:100001) manually as 24379 (presubmit successful).
6 years, 2 months ago (2014-10-02 07:22:07 UTC) #7
Hannes Payer (out of office)
6 years, 2 months ago (2014-10-02 07:22:10 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/583593006/diff/80001/src/heap/gc-idle-time-ha...
File src/heap/gc-idle-time-handler.cc (right):

https://codereview.chromium.org/583593006/diff/80001/src/heap/gc-idle-time-ha...
src/heap/gc-idle-time-handler.cc:107: // (1) If the new space is almost full and
we can effort a Scavenge or if the
On 2014/09/26 08:12:22, ulan wrote:
> nit: "we can _afford_ a Scavenge"?

Done.

Powered by Google App Engine
This is Rietveld 408576698