Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 583423002: Revert of Make mojo/services pass in "gn check" (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ui
Project:
chromium
Visibility:
Public.

Description

Revert of Make mojo/services pass in "gn check" (patchset #3 id:40001 of https://codereview.chromium.org/581273003/) Reason for revert: Broke component build Original issue's description: > Make mojo/services pass in "gn check" > > This mostly just adds the missing dependency identified by the checker. > > In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target. > > This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets. > > In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases. > > R=darin@chromium.org > > Committed: https://crrev.com/e2311613971cf63c66b60ebea38b4592b8520b8f > Cr-Commit-Position: refs/heads/master@{#295797} TBR=davemoore@chromium.org,darin@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5bbc04537e075ff313f34ef595dfef5050058173 Cr-Commit-Position: refs/heads/master@{#295801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -142 lines) Patch
M gpu/BUILD.gn View 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +3 lines, -6 lines 0 comments Download
M mojo/application_manager/BUILD.gn View 2 chunks +13 lines, -13 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 2 chunks +5 lines, -11 lines 0 comments Download
M mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +10 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 3 chunks +4 lines, -5 lines 0 comments Download
M mojo/services/clipboard/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/gles2/BUILD.gn View 2 chunks +2 lines, -9 lines 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/input_events/BUILD.gn View 2 chunks +13 lines, -11 lines 0 comments Download
M mojo/services/public/cpp/surfaces/BUILD.gn View 2 chunks +21 lines, -19 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 2 chunks +3 lines, -11 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 4 chunks +1 line, -8 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Created Revert of Make mojo/services pass in "gn check"
6 years, 3 months ago (2014-09-19 23:15:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583423002/1
6 years, 3 months ago (2014-09-19 23:16:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 35dc83f4c4bb2427cfc59da52e5d59e1caf54a9d
6 years, 3 months ago (2014-09-19 23:18:49 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:20:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bbc04537e075ff313f34ef595dfef5050058173
Cr-Commit-Position: refs/heads/master@{#295801}

Powered by Google App Engine
This is Rietveld 408576698