Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: mojo/services/view_manager/BUILD.gn

Issue 583423002: Revert of Make mojo/services pass in "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ui
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/test_service/test_service_impl.cc ('k') | mojo/services/window_manager/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/view_manager/BUILD.gn
diff --git a/mojo/services/view_manager/BUILD.gn b/mojo/services/view_manager/BUILD.gn
index 888b34b7e33577adba69a42a57c0e2f9d363f402..21b2796638cf08c7d0acf4033ede994c85cd2f0c 100644
--- a/mojo/services/view_manager/BUILD.gn
+++ b/mojo/services/view_manager/BUILD.gn
@@ -4,9 +4,6 @@
# GYP version: mojo/mojo_services.gypi:mojo_view_manager
component("view_manager") {
- public_deps = [
- "//mojo/services/public/cpp/view_manager:common",
- ]
deps = [
"//base",
"//cc/surfaces",
@@ -14,11 +11,10 @@
"//mojo/common",
"//mojo/environment:chromium",
"//mojo/public/c/system:for_component",
- "//mojo/public/cpp/bindings",
- "//mojo/public/interfaces/application",
"//mojo/services/public/cpp/geometry",
"//mojo/services/public/cpp/input_events",
"//mojo/services/public/cpp/surfaces",
+ "//mojo/services/public/cpp/view_manager:common",
"//mojo/services/public/interfaces/geometry",
"//mojo/services/public/interfaces/input_events",
"//mojo/services/public/interfaces/native_viewport",
@@ -64,13 +60,11 @@
# GYP version: mojo/mojo_services.gypi:mojo_view_manager_unittests
test("mojo_view_manager_unittests") {
deps = [
- ":view_manager",
"//base",
"//base/test:test_support",
"//mojo/application",
"//mojo/application_manager",
"//mojo/environment:chromium",
- "//mojo/public/cpp/bindings",
"//mojo/services/public/cpp/input_events",
"//mojo/services/public/cpp/geometry",
"//mojo/services/public/cpp/view_manager",
@@ -82,7 +76,6 @@
"//mojo/shell:test_support",
"//mojo/system",
"//testing/gtest",
- "//ui/gfx/geometry",
]
sources = [
« no previous file with comments | « mojo/services/test_service/test_service_impl.cc ('k') | mojo/services/window_manager/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698