Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 580993002: Revert of [ServivceWorker] Treat rejecting respondWith as a Network Error (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, mkwst+moarreviews_chromium.org, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [ServivceWorker] Treat rejecting respondWith as a Network Error (patchset #4 id:60001 of https://codereview.chromium.org/571843003/) Reason for revert: WebServiceWorkerResponse's status is not initialised. This may cause problems. I will re-land this patch after https://codereview.chromium.org/575153002/ is submitted. Original issue's description: > [ServivceWorker] Treat rejecting respondWith as a Network Error > > Chromium side change is this: https://codereview.chromium.org/574643003/ > > > BUG=411173 > TEST=layouttest http/tests/serviceworker/ > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182147 TBR=yhirano@chromium.org,mkwst@chromium.org,tkent@chromium.org,nhiroki@chromium.org NOTREECHECKS=true NOTRY=true BUG=411173 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-event.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 3 chunks +16 lines, -17 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
horo
Created Revert of [ServivceWorker] Treat rejecting respondWith as a Network Error
6 years, 3 months ago (2014-09-18 00:01:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580993002/1
6 years, 3 months ago (2014-09-18 00:02:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182204
6 years, 3 months ago (2014-09-18 00:03:23 UTC) #3
tkent
lgtm
6 years, 3 months ago (2014-09-18 01:04:56 UTC) #4
horo
6 years, 3 months ago (2014-09-19 01:22:47 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/585733002/ by horo@chromium.org.

The reason for reverting is: Landed the patch to initialize
WebServiceWorkerResponse's status.

https://codereview.chromium.org/575153002/.

Powered by Google App Engine
This is Rietveld 408576698