Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574643003: [ServiceWorker] Treat a response whose status is 0 as an error. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, mkwst+moarreviews-content_chromium.org, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Treat a response whose status is 0 as an error. BUG=411173 TEST=layouttest http/tests/serviceworker/ Committed: https://crrev.com/03545dd7b3b4bcd622b08d7dc4aacf8f7b864506 Cr-Commit-Position: refs/heads/master@{#295221}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove "always" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_url_request_job.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
horo
yhirano@ Could you please review?
6 years, 3 months ago (2014-09-16 09:02:15 UTC) #2
yhirano
https://codereview.chromium.org/574643003/diff/1/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/574643003/diff/1/content/browser/service_worker/service_worker_url_request_job.cc#newcode368 content/browser/service_worker/service_worker_url_request_job.cc:368: // Treat a response whose status is always 0 ...
6 years, 3 months ago (2014-09-17 01:35:29 UTC) #3
horo
https://codereview.chromium.org/574643003/diff/1/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/574643003/diff/1/content/browser/service_worker/service_worker_url_request_job.cc#newcode368 content/browser/service_worker/service_worker_url_request_job.cc:368: // Treat a response whose status is always 0 ...
6 years, 3 months ago (2014-09-17 01:41:09 UTC) #4
yhirano
lgtm
6 years, 3 months ago (2014-09-17 02:26:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/574643003/20001
6 years, 3 months ago (2014-09-17 02:31:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4390551aab38bb5bb60523c31fb912d1c6f93592
6 years, 3 months ago (2014-09-17 03:29:27 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 03:30:15 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/03545dd7b3b4bcd622b08d7dc4aacf8f7b864506
Cr-Commit-Position: refs/heads/master@{#295221}

Powered by Google App Engine
This is Rietveld 408576698