Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 580703002: Code re-factor related to WeakPtrFactory in src/gin module (Closed)

Created:
6 years, 3 months ago by ARUNKK
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Code re-factor related to WeakPtrFactory in src/gin module Changing in the initialization order of WeakPtrFactory in src/gin module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructor are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/71a12a87117d7c88f02ec2c75b81726d12cbcc1a Cr-Commit-Position: refs/heads/master@{#295709}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M gin/modules/timer.h View 1 chunk +2 lines, -1 line 1 comment Download
M gin/modules/timer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ARUNKK
PTAL.
6 years, 3 months ago (2014-09-17 05:19:53 UTC) #2
ARUNKK
PTAL.
6 years, 3 months ago (2014-09-19 07:16:56 UTC) #4
ARUNKK
6 years, 3 months ago (2014-09-19 07:17:15 UTC) #6
jochen (gone - plz use gerrit)
lgtm with nit https://codereview.chromium.org/580703002/diff/1/gin/modules/timer.h File gin/modules/timer.h (right): https://codereview.chromium.org/580703002/diff/1/gin/modules/timer.h#newcode44 gin/modules/timer.h:44: nit. no empty line while you ...
6 years, 3 months ago (2014-09-19 13:30:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580703002/1
6 years, 3 months ago (2014-09-19 13:32:51 UTC) #9
ARUNKK
On 2014/09/19 13:30:36, jochen (slow for reviews) wrote: > lgtm with nit > > https://codereview.chromium.org/580703002/diff/1/gin/modules/timer.h ...
6 years, 3 months ago (2014-09-19 13:44:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as fa62a2308be795b4b8c6850d8015cb81f843da89
6 years, 3 months ago (2014-09-19 15:05:14 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 15:05:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71a12a87117d7c88f02ec2c75b81726d12cbcc1a
Cr-Commit-Position: refs/heads/master@{#295709}

Powered by Google App Engine
This is Rietveld 408576698