gin/modules/timer.h - Issue 580703002: Code re-factor related to WeakPtrFactory in src/gin module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/timer.h

Issue 580703002: Code re-factor related to WeakPtrFactory in src/gin module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/modules/timer.h

diff --git a/gin/modules/timer.h b/gin/modules/timer.h

index e2bed2e56fbee24cbed89949c97a9e0f6630be7b..da17fe14822886cc73bd6c03d2bb728360afbbe9 100644

--- a/gin/modules/timer.h

+++ b/gin/modules/timer.h

@@ -38,9 +38,10 @@ class GIN_EXPORT Timer : public Wrappable<Timer> {

virtual ~Timer();

void OnTimerFired();

- base::WeakPtrFactory<Timer> weak_factory_;

base::Timer timer_;

base::WeakPtr<gin::Runner> runner_;

+ base::WeakPtrFactory<Timer> weak_factory_;

jochen (gone - plz use gerrit) 2014/09/19 13:30:36 nit. no empty line while you touch this class any

};

« no previous file with comments | « no previous file | gin/modules/timer.cc » ('j') | no next file with comments »