Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: gin/modules/timer.h

Issue 580703002: Code re-factor related to WeakPtrFactory in src/gin module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gin/modules/timer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_MODULES_TIMER_H_ 5 #ifndef GIN_MODULES_TIMER_H_
6 #define GIN_MODULES_TIMER_H_ 6 #define GIN_MODULES_TIMER_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "base/timer/timer.h" 9 #include "base/timer/timer.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 20 matching lines...) Expand all
31 31
32 virtual ObjectTemplateBuilder GetObjectTemplateBuilder( 32 virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
33 v8::Isolate* isolate) OVERRIDE; 33 v8::Isolate* isolate) OVERRIDE;
34 34
35 private: 35 private:
36 Timer(v8::Isolate* isolate, bool repeating, int delay_ms, 36 Timer(v8::Isolate* isolate, bool repeating, int delay_ms,
37 v8::Handle<v8::Function> function); 37 v8::Handle<v8::Function> function);
38 virtual ~Timer(); 38 virtual ~Timer();
39 void OnTimerFired(); 39 void OnTimerFired();
40 40
41 base::WeakPtrFactory<Timer> weak_factory_;
42 base::Timer timer_; 41 base::Timer timer_;
43 base::WeakPtr<gin::Runner> runner_; 42 base::WeakPtr<gin::Runner> runner_;
43 base::WeakPtrFactory<Timer> weak_factory_;
44
jochen (gone - plz use gerrit) 2014/09/19 13:30:36 nit. no empty line while you touch this class any
44 }; 45 };
45 46
46 47
47 class GIN_EXPORT TimerModule : public Wrappable<TimerModule> { 48 class GIN_EXPORT TimerModule : public Wrappable<TimerModule> {
48 public: 49 public:
49 static const char kName[]; 50 static const char kName[];
50 static WrapperInfo kWrapperInfo; 51 static WrapperInfo kWrapperInfo;
51 static Handle<TimerModule> Create(v8::Isolate* isolate); 52 static Handle<TimerModule> Create(v8::Isolate* isolate);
52 static v8::Local<v8::Value> GetModule(v8::Isolate* isolate); 53 static v8::Local<v8::Value> GetModule(v8::Isolate* isolate);
53 54
54 private: 55 private:
55 TimerModule(); 56 TimerModule();
56 virtual ~TimerModule(); 57 virtual ~TimerModule();
57 58
58 virtual ObjectTemplateBuilder GetObjectTemplateBuilder( 59 virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
59 v8::Isolate* isolate) OVERRIDE; 60 v8::Isolate* isolate) OVERRIDE;
60 }; 61 };
61 62
62 } // namespace gin 63 } // namespace gin
63 64
64 #endif // GIN_MODULES_TIMER_H_ 65 #endif // GIN_MODULES_TIMER_H_
OLDNEW
« no previous file with comments | « no previous file | gin/modules/timer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698