Fix the indirect pure virtual calls in DataFetcherSharedMemoryBase destructor.

content/browser/device_sensors/data_fetcher_shared_memory_base.h

Index: content/browser/device_sensors/data_fetcher_shared_memory_base.h
diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_base.h b/content/browser/device_sensors/data_fetcher_shared_memory_base.h
index c959e8254fd6dfadb922289ce75e8e246663a1ec..f98e9720fad2505d2eccfb7c93ce42a29d7fe3ad 100644
--- a/content/browser/device_sensors/data_fetcher_shared_memory_base.h
+++ b/content/browser/device_sensors/data_fetcher_shared_memory_base.h
@@ -77,6 +77,10 @@ class CONTENT_EXPORT DataFetcherSharedMemoryBase {
 
   bool IsPollingTimerRunningForTesting() const;
 
+  // Should be used in deriving classes to make sure all active sensors are

[Bernhard Bauer, 2014/09/17 16:41:00]

Nit: "derived"

[timvolodine, 2014/09/17 18:25:00]

Done.

+  // unregistered upon destruction.
+  void StopFetchingAllDeviceData();

[Bernhard Bauer, 2014/09/17 16:41:00]

Instead of requiring each subclass to call this method in its destructor,
couldn't you make this method public and call it before the owner destroys this
object?

[timvolodine, 2014/09/17 18:25:00]

Done. though not sure it's that much better..

[Bernhard Bauer, 2014/09/17 21:36:37]

Well, it means you only have to care about this in two places in one file, one
of these places being testing code.

(Really, the way around this would be to use delegation instead of
implementation inheritance).

+
  private:
   bool InitAndStartPollingThreadIfNecessary();
   base::SharedMemory* GetSharedMemory(ConsumerType consumer_type);