content/browser/device_sensors/data_fetcher_shared_memory_android.cc - Issue 578863002: Fix the indirect pure virtual calls in DataFetcherSharedMemoryBase destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_android.cc

Issue 578863002: Fix the indirect pure virtual calls in DataFetcherSharedMemoryBase destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comment in data_fetcher_shared_memory_base Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/device_sensors/data_fetcher_shared_memory_base.h » ('j') | content/browser/device_sensors/data_fetcher_shared_memory_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/data_fetcher_shared_memory_android.cc

diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_android.cc b/content/browser/device_sensors/data_fetcher_shared_memory_android.cc

index 2ed5f7fc0f9d78080411b6868f19e837a388a3ab..296634dfa8bbc7858e8d6e1bbdf9f1fe8cad76d0 100644

--- a/content/browser/device_sensors/data_fetcher_shared_memory_android.cc

+++ b/content/browser/device_sensors/data_fetcher_shared_memory_android.cc

@@ -15,6 +15,7 @@ DataFetcherSharedMemory::DataFetcherSharedMemory() {

}

DataFetcherSharedMemory::~DataFetcherSharedMemory() {

+ StopFetchingAllDeviceData();

}

bool DataFetcherSharedMemory::Start(ConsumerType consumer_type, void* buffer) {