Fix the indirect pure virtual calls in DataFetcherSharedMemoryBase destructor.

content/browser/device_sensors/data_fetcher_shared_memory_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVICE_SENSORS_DATA_FETCHER_SHARED_MEMORY_BASE_H_
 #define CONTENT_BROWSER_DEVICE_SENSORS_DATA_FETCHER_SHARED_MEMORY_BASE_H_
 
 #include <map>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 59 matching lines @@
   virtual base::TimeDelta GetInterval() const;
 
   // Start() method should call InitSharedMemoryBuffer() to get the shared
   // memory pointer. If IsPolling() is true both Start() and Stop() methods
   // are called from the |polling_thread_|.
   virtual bool Start(ConsumerType consumer_type, void* buffer) = 0;
   virtual bool Stop(ConsumerType consumer_type) = 0;
 
   bool IsPollingTimerRunningForTesting() const;
 
+  // Should be used in deriving classes to make sure all active sensors are

[Bernhard Bauer, 2014/09/17 16:41:00]

Nit: "derived"

[timvolodine, 2014/09/17 18:25:00]

Done.

+  // unregistered upon destruction.
+  void StopFetchingAllDeviceData();

[Bernhard Bauer, 2014/09/17 16:41:00]

Instead of requiring each subclass to call this method in its destructor,
couldn't you make this method public and call it before the owner destroys this
object?

[timvolodine, 2014/09/17 18:25:00]

Done. though not sure it's that much better..

[Bernhard Bauer, 2014/09/17 21:36:37]

Well, it means you only have to care about this in two places in one file, one
of these places being testing code.

(Really, the way around this would be to use delegation instead of
implementation inheritance).

+
  private:
   bool InitAndStartPollingThreadIfNecessary();
   base::SharedMemory* GetSharedMemory(ConsumerType consumer_type);
   void* GetSharedMemoryBuffer(ConsumerType consumer_type);
 
   unsigned started_consumers_;
 
   scoped_ptr<PollingThread> polling_thread_;
 
   // Owning pointers. Objects in the map are deleted in dtor.
   typedef std::map<ConsumerType, base::SharedMemory*> SharedMemoryMap;
   SharedMemoryMap shared_memory_map_;
 
   DISALLOW_COPY_AND_ASSIGN(DataFetcherSharedMemoryBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DEVICE_SENSORS_DATA_FETCHER_SHARED_MEMORY_BASE_H_