Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 578693002: Revert of Revert of Introduce GetBackendFromContextId to avoid using list index. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
achuithb, tonyg, tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/573573003/) Reason for revert: Revert the revert since the bot is still red after the revert. Original issue's description: > Revert of Introduce GetBackendFromContextId to avoid using list index. (patchset #1 id:1 of https://codereview.chromium.org/556003005/) > > Reason for revert: > It looks like the moto E perf bots are broken due to this change. > > BUG=414267 > > Original issue's description: > > Introduce GetBackendFromContextId to avoid using list index. > > > > BUG=398467 > > TEST=ExtensionTest > > > > Committed: https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc > > Cr-Commit-Position: refs/heads/master@{#294455} > > TBR=tbarzic@chromium.org,achuith@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=398467 > > Committed: https://crrev.com/c8fad04c1e2119f9e8efc68f32d5268161d044d3 > Cr-Commit-Position: refs/heads/master@{#295136} TBR=tbarzic@chromium.org,achuith@chromium.org,tonyg@chromium.org NOTREECHECKS=true NOTRY=true BUG=414267 Committed: https://crrev.com/872bf7868e04a6354f20d66d069cb623b1a70298 Cr-Commit-Position: refs/heads/master@{#295205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/extension_backend.py View 1 chunk +3 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nednguyen
Created Revert of Revert of Introduce GetBackendFromContextId to avoid using list index.
6 years, 3 months ago (2014-09-17 01:10:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/578693002/1
6 years, 3 months ago (2014-09-17 01:13:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d10989a5b63f2f29618ccdbad310e409cb97cc96
6 years, 3 months ago (2014-09-17 01:14:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 01:14:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/872bf7868e04a6354f20d66d069cb623b1a70298
Cr-Commit-Position: refs/heads/master@{#295205}

Powered by Google App Engine
This is Rietveld 408576698