tools/telemetry/telemetry/core/backends/chrome/extension_backend.py - Issue 578693002: Revert of Revert of Introduce GetBackendFromContextId to avoid using list index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/extension_backend.py

Issue 578693002: Revert of Revert of Introduce GetBackendFromContextId to avoid using list index. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/extension_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py b/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py

index 68a00a692206fe52a1bc31230adc36af61a8e743..70f67f86fa0cf867171b7f6c9e7c80c604d9a663 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py

@@ -25,16 +25,12 @@

def __init__(self, browser_backend):

self._extension_backend_list = ExtensionBackendList(browser_backend)

- def __contains__(self, extension_id):

- return (extension_id in

- (self.ContextIdToExtensionId(context_id)

- for context_id in self._extension_backend_list))

def __getitem__(self, extension_id):

extensions = []

- for i, context_id in enumerate(self._extension_backend_list):

+ for context_id in self._extension_backend_list:

if self.ContextIdToExtensionId(context_id) == extension_id:

- extensions.append(self._extension_backend_list[i])

+ extensions.append(

+ self._extension_backend_list.GetBackendFromContextId(context_id))

if not extensions:

raise KeyError('Cannot find an extension with id=%s' % extension_id)

return extensions