tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 578693002: Revert of Revert of Introduce GetBackendFromContextId to avoid using list index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 578693002: Revert of Revert of Introduce GetBackendFromContextId to avoid using list index. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 4306c9707ba7800a725e199c71ac8a9fe8c1d45a..50d16f5dc8e0f4dc5607f6a3f39723295d4913d1 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -160,9 +160,11 @@

document.readyState == 'interactive')

"""

for e in self._extensions_to_load:

- if not e.extension_id in self.extension_backend:

+ try:

+ extension_objects = self.extension_backend[e.extension_id]

+ except KeyError:

return False

- for extension_object in self.extension_backend[e.extension_id]:

+ for extension_object in extension_objects:

try:

res = extension_object.EvaluateJavaScript(

extension_ready_js % e.extension_id)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/extension_backend.py » ('j') | no next file with comments »