Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 577953003: [Nit] Use write_text_file directly instead of open_text_file_for_writing followed by write (Closed)

Created:
6 years, 3 months ago by patro
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Nit] Use write_text_file directly instead of open_text_file_for_writing followed by write Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182166

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
patro
Kindly Review Thanks, Shyam Patro
6 years, 3 months ago (2014-09-17 13:55:45 UTC) #3
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-17 15:19:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/577953003/20001
6 years, 3 months ago (2014-09-17 15:47:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 16:49:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 182166

Powered by Google App Engine
This is Rietveld 408576698