Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py - Issue 577953003: [Nit] Use write_text_file directly instead of open_text_file_for_writing followed by write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

Issue 577953003: [Nit] Use write_text_file directly instead of open_text_file_for_writing followed by write (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py b/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

index d47c48fe870a42ea35659ecc02849ec24862cb12..0ef780f5e9ccee1bfaa613ce53c49a14a649f1fd 100644

--- a/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

+++ b/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

@@ -152,5 +152,5 @@ class GenerateDashBoard(object):

self._final_result = process_json_data.generate_archived_result()

final_json = json.dumps(self._final_result)

final_json = 'ADD_RESULTS(' + final_json + ');'

- with self._filesystem.open_text_file_for_writing(self._filesystem.join(self._results_directory, 'archived_results.json')) as file:

- file.write(final_json)

+ archived_results_file_path = self._filesystem.join(self._results_directory, 'archived_results.json')

+ self._filesystem.write_text_file(archived_results_file_path, final_json)

« no previous file with comments | « no previous file | no next file » | no next file with comments »