Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py - Issue 577953003: [Nit] Use write_text_file directly instead of open_text_file_for_writing followed by write

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

Issue 577953003: [Nit] Use write_text_file directly instead of open_text_file_for_writing followed by write (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright (C) 2014 Google Inc. All rights reserved.	1 # Copyright (C) 2014 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 134 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
145	145

146 def generate(self):	146 def generate(self):

147 self._initialize()	147 self._initialize()

148	148

149 # There must be atleast one archived result to be processed	149 # There must be atleast one archived result to be processed

150 if self._current_result_json_dict:	150 if self._current_result_json_dict:

151 process_json_data = ProcessJsonData(self._current_result_json_dict, self._old_failing_results_list, self._old_full_results_list)	151 process_json_data = ProcessJsonData(self._current_result_json_dict, self._old_failing_results_list, self._old_full_results_list)

152 self._final_result = process_json_data.generate_archived_result()	152 self._final_result = process_json_data.generate_archived_result()

153 final_json = json.dumps(self._final_result)	153 final_json = json.dumps(self._final_result)

154 final_json = 'ADD_RESULTS(' + final_json + ');'	154 final_json = 'ADD_RESULTS(' + final_json + ');'

155 with self._filesystem.open_text_file_for_writing(self._filesystem.jo in(self._results_directory, 'archived_results.json')) as file:	155 archived_results_file_path = self._filesystem.join(self._results_dir ectory, 'archived_results.json')

156 file.write(final_json)	156 self._filesystem.write_text_file(archived_results_file_path, final_j son)

OLD	NEW