Refactoring the WeakPtrFactory initialization in chrome/browser/ui/views

Refactoring the WeakPtrFactory initialization in chrome/browser/ui/views

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/1da4b61e9a74451f0b3a136b9b8228ee4d232c23
Cr-Commit-Position: refs/heads/master@{#295404}

[MRV, 2014-09-16 03:27:04]

mohan.reddy@samsung.com changed reviewers:
+ sky@chromium.org

[MRV, 2014-09-16 03:27:05]

PTAL

[MRV, 2014-09-17 18:13:50]

On 2014/09/16 03:27:05, MRV wrote:
> PTAL

@mr.sky could you please check my patch.

[sky, 2014-09-17 19:44:07]

LGTM

[MRV, 2014-09-18 01:58:36]

The CQ bit was checked by mohan.reddy@samsung.com

[MRV, 2014-09-18 01:59:07]

On 2014/09/17 19:44:07, sky wrote:
> LGTM

Dear mr.sky..
Thanks for lgtm

[commit-bot: I haz the power, 2014-09-18 01:59:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/577523002/40001

[commit-bot: I haz the power, 2014-09-18 02:58:04]

Committed patchset #3 (id:40001) as a84ad8dd15068329149a885e06f2f8f30f9314b6

[commit-bot: I haz the power, 2014-09-18 02:59:32]

Patchset 3 (id:??) landed as
https://crrev.com/1da4b61e9a74451f0b3a136b9b8228ee4d232c23
Cr-Commit-Position: refs/heads/master@{#295404}