chrome/browser/ui/views/extensions/extension_message_bubble_view.cc - Issue 577523002: Refactoring the WeakPtrFactory initialization in chrome/browser/ui/views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 577523002: Refactoring the WeakPtrFactory initialization in chrome/browser/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolved Rebase issues Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_message_bubble_view.h ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

index d741779cffa7d82b45c9bee97c9d1a34de763f87..b33beb60edb0bf900cfc313a63b8c207b7e3618d 100644

--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

@@ -62,14 +62,14 @@ ExtensionMessageBubbleView::ExtensionMessageBubbleView(

views::BubbleBorder::Arrow arrow_location,

scoped_ptr<extensions::ExtensionMessageBubbleController> controller)

: BubbleDelegateView(anchor_view, arrow_location),

- weak_factory_(this),

controller_(controller.Pass()),

anchor_view_(anchor_view),

headline_(NULL),

learn_more_(NULL),

dismiss_button_(NULL),

link_clicked_(false),

- action_taken_(false) {

+ action_taken_(false),

+ weak_factory_(this) {

DCHECK(anchor_view->GetWidget());

set_close_on_deactivate(controller_->CloseOnDeactivate());

set_close_on_esc(true);