Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.h

Issue 577523002: Refactoring the WeakPtrFactory initialization in chrome/browser/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved Rebase issues Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.h
diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.h b/chrome/browser/ui/views/extensions/extension_message_bubble_view.h
index 322139f14a58d181fe109910a41086f6061ce6df..ad74a5cf07649429df5d80177f57df8fbd232bda 100644
--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.h
+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.h
@@ -182,8 +182,6 @@ class ExtensionMessageBubbleView : public ExtensionMessageBubble,
virtual void ViewHierarchyChanged(const ViewHierarchyChangedDetails& details)
OVERRIDE;
- base::WeakPtrFactory<ExtensionMessageBubbleView> weak_factory_;
-
// The controller for this bubble.
scoped_ptr<ExtensionMessageBubbleController> controller_;
@@ -206,6 +204,8 @@ class ExtensionMessageBubbleView : public ExtensionMessageBubble,
base::Closure dismiss_callback_;
base::Closure link_callback_;
+ base::WeakPtrFactory<ExtensionMessageBubbleView> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleView);
};

Powered by Google App Engine
This is Rietveld 408576698