Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 577333002: Add and use CheckedReadFD(), CheckedWriteFD(), and CheckedReadFDAtEOF() (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add and use CheckedReadFD(), CheckedWriteFD(), and CheckedReadFDAtEOF(). TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/eeaf460f820752a95ec91cbd29d76c9f7018de85

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -156 lines) Patch
M util/file/fd_io.h View 2 chunks +34 lines, -0 lines 0 comments Download
M util/file/fd_io.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M util/mac/process_reader_test.cc View 11 chunks +40 lines, -112 lines 2 comments Download
M util/mach/exception_ports_test.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 5 chunks +4 lines, -9 lines 0 comments Download
M util/test/multiprocess_exec_test.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M util/test/multiprocess_test.cc View 2 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-18 18:14:47 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/577333002/diff/1/util/mac/process_reader_test.cc File util/mac/process_reader_test.cc (left): https://codereview.chromium.org/577333002/diff/1/util/mac/process_reader_test.cc#oldcode491 util/mac/process_reader_test.cc:491: ssize_t rv = WriteFD(write_fd, &c, 1); This delete ...
6 years, 3 months ago (2014-09-18 19:02:15 UTC) #3
Mark Mentovai
https://codereview.chromium.org/577333002/diff/1/util/mac/process_reader_test.cc File util/mac/process_reader_test.cc (left): https://codereview.chromium.org/577333002/diff/1/util/mac/process_reader_test.cc#oldcode491 util/mac/process_reader_test.cc:491: ssize_t rv = WriteFD(write_fd, &c, 1); rsesek wrote: > ...
6 years, 3 months ago (2014-09-18 19:03:11 UTC) #4
Mark Mentovai
6 years, 3 months ago (2014-09-18 19:03:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as eeaf460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698