Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: util/test/multiprocess_exec_test.cc

Issue 577333002: Add and use CheckedReadFD(), CheckedWriteFD(), and CheckedReadFDAtEOF() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/test/multiprocess_exec_test.cc
diff --git a/util/test/multiprocess_exec_test.cc b/util/test/multiprocess_exec_test.cc
index 0edbbcf0feb7117739205029d0fe953f17e2bf0a..2f30b9b038450dce53a7b8c3931c060e6500dc65 100644
--- a/util/test/multiprocess_exec_test.cc
+++ b/util/test/multiprocess_exec_test.cc
@@ -19,7 +19,6 @@
#include "base/basictypes.h"
#include "gtest/gtest.h"
#include "util/file/fd_io.h"
-#include "util/test/errors.h"
#include "util/test/executable_path.h"
namespace {
@@ -35,14 +34,10 @@ class TestMultiprocessExec final : public MultiprocessExec {
private:
virtual void MultiprocessParent() override {
- int write_fd = WritePipeFD();
char c = 'z';
- ssize_t rv = WriteFD(write_fd, &c, 1);
- ASSERT_EQ(1, rv) << ErrnoMessage("write");
+ CheckedWriteFD(WritePipeFD(), &c, 1);
- int read_fd = ReadPipeFD();
- rv = ReadFD(read_fd, &c, 1);
- ASSERT_EQ(1, rv) << ErrnoMessage("read");
+ CheckedReadFD(ReadPipeFD(), &c, 1);
EXPECT_EQ('Z', c);
}

Powered by Google App Engine
This is Rietveld 408576698