Add and use CheckedReadFD(), CheckedWriteFD(), and CheckedReadFDAtEOF()

util/test/multiprocess_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/test/multiprocess.h"
 
 #include <stdlib.h>
 #include <sys/signal.h>
 #include <unistd.h>
 
 #include "base/basictypes.h"
 #include "gtest/gtest.h"
 #include "util/file/fd_io.h"
-#include "util/test/errors.h"
 
 namespace {
 
 using namespace crashpad;
 using namespace crashpad::test;
 
 class TestMultiprocess final : public Multiprocess {
  public:
   TestMultiprocess() : Multiprocess() {}
 
   ~TestMultiprocess() {}
 
  private:
   virtual void MultiprocessParent() override {
     int read_fd = ReadPipeFD();
     char c;
-    ssize_t rv = ReadFD(read_fd, &c, 1);
-    ASSERT_EQ(1, rv) << ErrnoMessage("read");
+    CheckedReadFD(read_fd, &c, 1);
     EXPECT_EQ('M', c);
 
     pid_t pid;
-    rv = ReadFD(read_fd, &pid, sizeof(pid));
-    ASSERT_EQ(static_cast<ssize_t>(sizeof(pid)), rv) << ErrnoMessage("read");
+    CheckedReadFD(read_fd, &pid, sizeof(pid));
     EXPECT_EQ(pid, ChildPID());
 
-    int write_fd = WritePipeFD();
     c = 'm';
-    rv = WriteFD(write_fd, &c, 1);
-    ASSERT_EQ(1, rv) << ErrnoMessage("write");
+    CheckedWriteFD(WritePipeFD(), &c, 1);
 
     // The child will close its end of the pipe and exit. Make sure that the
     // parent sees EOF.
-    rv = ReadFD(read_fd, &c, 1);
-    ASSERT_EQ(0, rv) << ErrnoMessage("read");
+    CheckedReadFDAtEOF(read_fd);
   }
 
   virtual void MultiprocessChild() override {
     int write_fd = WritePipeFD();
 
     char c = 'M';
-    ssize_t rv = WriteFD(write_fd, &c, 1);
-    ASSERT_EQ(1, rv) << ErrnoMessage("write");
+    CheckedWriteFD(write_fd, &c, 1);
 
     pid_t pid = getpid();
-    rv = WriteFD(write_fd, &pid, sizeof(pid));
-    ASSERT_EQ(static_cast<ssize_t>(sizeof(pid)), rv) << ErrnoMessage("write");
+    CheckedWriteFD(write_fd, &pid, sizeof(pid));
 
-    int read_fd = ReadPipeFD();
-    rv = ReadFD(read_fd, &c, 1);
-    ASSERT_EQ(1, rv) << ErrnoMessage("read");
+    CheckedReadFD(ReadPipeFD(), &c, 1);
     EXPECT_EQ('m', c);
   }
 
   DISALLOW_COPY_AND_ASSIGN(TestMultiprocess);
 };
 
 TEST(Multiprocess, Multiprocess) {
   TestMultiprocess multiprocess;
   multiprocess.Run();
 }
@@ skipping 54 matching lines @@
   TestMultiprocessUnclean multiprocess(TestMultiprocessUnclean::kExit2);
   multiprocess.Run();
 }
 
 TEST(Multiprocess, MultiprocessAbortSignal) {
   TestMultiprocessUnclean multiprocess(TestMultiprocessUnclean::kAbort);
   multiprocess.Run();
 }
 
 }  // namespace