Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 576383002: easy-signin: Wire GetSignInChallenge. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
Reviewers:
Tim Song, tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

easy-signin: Wire GetSignInChallenge. - Fetch crypthome keys when EasyUnlockServiceSignIn is assocated with a user; - Translate and provide remote devices and challenge from key data; BUG=401636 Committed: https://crrev.com/048cedfbcda51787df4674c96ad2bd534aff9941 Cr-Commit-Position: refs/heads/master@{#295610}

Patch Set 1 #

Patch Set 2 : rebase, add fake key #

Messages

Total messages: 8 (2 generated)
xiyuan
Not ready for review yet. Just a heads up. Will ping back when I tested ...
6 years, 3 months ago (2014-09-18 00:20:35 UTC) #2
xiyuan
Manually tested it by hard coding a user name on service initialize and use dev ...
6 years, 3 months ago (2014-09-18 21:04:33 UTC) #3
tbarzic
lgtm
6 years, 3 months ago (2014-09-18 21:12:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576383002/20001
6 years, 3 months ago (2014-09-18 23:16:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e1e90ad08a0cc585e151469999dbae54ad4ef997
6 years, 3 months ago (2014-09-18 23:49:30 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:50:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/048cedfbcda51787df4674c96ad2bd534aff9941
Cr-Commit-Position: refs/heads/master@{#295610}

Powered by Google App Engine
This is Rietveld 408576698