chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc - Issue 576383002: easy-signin: Wire GetSignInChallenge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

Issue 576383002: easy-signin: Wire GetSignInChallenge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, add fake key Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h ('k') | chrome/browser/signin/easy_unlock_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

index 6bbdc5cc8b47901689036493f648b66f81fa1ece..c8cc9273f78a3ef461e3b429cd4561ba26679331 100644

--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

@@ -541,9 +541,14 @@ EasyUnlockPrivateGetSignInChallengeFunction::

~EasyUnlockPrivateGetSignInChallengeFunction() {

}

-bool EasyUnlockPrivateGetSignInChallengeFunction::RunAsync() {

- SetError("Not implemented");

- SendResponse(false);

+bool EasyUnlockPrivateGetSignInChallengeFunction::RunSync() {

+ Profile* profile = Profile::FromBrowserContext(browser_context());

+ const std::string challenge =

+ EasyUnlockService::Get(profile)->GetChallenge();

+ if (!challenge.empty()) {

+ results_ =

+ easy_unlock_private::GetSignInChallenge::Results::Create(challenge);

+ }

return true;

}