chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h - Issue 576383002: easy-signin: Wire GetSignInChallenge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h

Issue 576383002: easy-signin: Wire GetSignInChallenge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, add fake key Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc ('k') | chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h

diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h

index 654726c821edd579513c020e5194a502e3c813c8..02e58c1a55b85aca50e731d5e821b85be37cc30d 100644

--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h

+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h

@@ -279,7 +279,7 @@ class EasyUnlockPrivateGetRemoteDevicesFunction : public SyncExtensionFunction {

};

class EasyUnlockPrivateGetSignInChallengeFunction :

- public AsyncExtensionFunction {

+ public SyncExtensionFunction {

public:

DECLARE_EXTENSION_FUNCTION("easyUnlockPrivate.getSignInChallenge",

EASYUNLOCKPRIVATE_GETSIGNINCHALLENGE)

@@ -288,8 +288,8 @@ class EasyUnlockPrivateGetSignInChallengeFunction :

private:

virtual ~EasyUnlockPrivateGetSignInChallengeFunction();

- // AsyncExtensionFunction:

- virtual bool RunAsync() OVERRIDE;

+ // SyncExtensionFunction:

+ virtual bool RunSync() OVERRIDE;

DISALLOW_COPY_AND_ASSIGN(EasyUnlockPrivateGetSignInChallengeFunction);

};