Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 575373004: Convert KeyedLoad indexed interceptor case to a Handler. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Convert KeyedLoad indexed interceptor case to a Handler. Currently, KeyedLoads on objects with indexed interceptors are handled with a special stub. Instead, key on the map and handler mechanism for more uniform treatment. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24042

Patch Set 1 #

Patch Set 2 : REBASE and ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -235 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/builtins.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 1 chunk +0 lines, -42 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/ic/ic.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mvstanton
Hi Toon, here is the second in the series of two CLs we discussed, this ...
6 years, 3 months ago (2014-09-18 08:07:43 UTC) #1
Toon Verwaest
lgtm
6 years, 3 months ago (2014-09-18 11:58:37 UTC) #2
mvstanton
6 years, 3 months ago (2014-09-18 13:28:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 24042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698