Fail if an isolate entry refers to a missing file.

Fail if an isolate entry refers to a missing file.

This might have been useful before while trying to get the system running. But now we have swarming running on Linux/Mac/Windows trybots, so it's not so useful. It's also confusing when tests fail on swarming machines because an isolate file referred to a binary that wasn't in the dependencies.

BUG=414808
Committed: https://crrev.com/6d2b3cd041bcded84f6f82f1fbac2348e2d7a9df
Cr-Commit-Position: refs/heads/master@{#295514}

[jam, 2014-09-18 14:57:39]

jam@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2014-09-18 15:38:53]

It'd be necessary to fix OSX too;
https://code.google.com/p/chromium/issues/detail?id=415188

Basically, lib32 doesn't exist on 64 bits build, and a test showed that this
directory is actually needed on 32 bits build. I assume a 64 bit builds need a
lib64 (I haven't confirmed).

https://codereview.chromium.org/575363002/diff/60001/chrome/chrome.isolate
File chrome/chrome.isolate (right):

https://codereview.chromium.org/575363002/diff/60001/chrome/chrome.isolate#ne...
chrome/chrome.isolate:71: '<(PRODUCT_DIR)/nacl64.exe',
You mean 32?

[jam, 2014-09-18 15:44:45]

On 2014/09/18 15:38:53, M-A Ruel wrote:
> It'd be necessary to fix OSX too;
> https://code.google.com/p/chromium/issues/detail?id=415188
> 
> Basically, lib32 doesn't exist on 64 bits build, and a test showed that this
> directory is actually needed on 32 bits build. I assume a 64 bit builds need a
> lib64 (I haven't confirmed).

I read the bug, but I'm not sure why that's needed to enable strict checking?
Per the bug, Nico disabled isolate on that builder.

My intent with this change is just that no trybot or waterfall builder fails
with this cl, but not necessarily to fix anything else. If this lands as is, do
you know of any builder which would fail?

https://codereview.chromium.org/575363002/diff/60001/chrome/chrome.isolate
File chrome/chrome.isolate (right):

https://codereview.chromium.org/575363002/diff/60001/chrome/chrome.isolate#ne...
chrome/chrome.isolate:71: '<(PRODUCT_DIR)/nacl64.exe',
On 2014/09/18 15:38:52, M-A Ruel wrote:
> You mean 32?

nacl64.exe is needed with 32 bit builds of Chrome when they're run on a 64 bit
version of Windows. For 64-bit versions of Chrome, no such binary is needed

[M-A Ruel, 2014-09-18 17:03:20]

lgtm

https://codereview.chromium.org/575363002/diff/60001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/575363002/diff/60001/build/common.gypi#newcod...
build/common.gypi:594: 'test_isolation_fail_on_missing': 1,
One last thing; I'm not 100% sure it's worth keeping the flag and my last
attempt was removing it altogether. I guess there's cases where it could be
valuable temporarily.

[jam, 2014-09-18 17:05:01]

https://codereview.chromium.org/575363002/diff/60001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/575363002/diff/60001/build/common.gypi#newcod...
build/common.gypi:594: 'test_isolation_fail_on_missing': 1,
On 2014/09/18 17:03:20, M-A Ruel wrote:
> One last thing; I'm not 100% sure it's worth keeping the flag and my last
> attempt was removing it altogether. I guess there's cases where it could be
> valuable temporarily.

well I'm not sure that all bots will succeed (i.e. waterfall). so I'd like to
land a minimal change, and let's see if things are green. we can then remove it
as a followup.

[jam, 2014-09-18 17:05:05]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/575363002/60001

[commit-bot: I haz the power, 2014-09-18 17:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:16:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2014-09-18 17:21:59]

jam@chromium.org changed reviewers:
+ yzshen@chromium.org

[jam, 2014-09-18 17:21:59]

+yzshen for mojo

[yzshen1, 2014-09-18 18:30:36]

lgtm

[jam, 2014-09-18 19:01:28]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-18 19:02:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/575363002/60001

[commit-bot: I haz the power, 2014-09-18 19:08:57]

Committed patchset #4 (id:60001) as 5644717c5ac3b65f510fd8dc00053d10688fa0c1

[commit-bot: I haz the power, 2014-09-18 19:09:37]

Patchset 4 (id:??) landed as
https://crrev.com/6d2b3cd041bcded84f6f82f1fbac2348e2d7a9df
Cr-Commit-Position: refs/heads/master@{#295514}