Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: build/common.gypi

Issue 575363002: Fail if an isolate entry refers to a missing file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome.isolate » ('j') | chrome/chrome.isolate » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 'use_canvas_skia%': 0, 584 'use_canvas_skia%': 0,
585 585
586 # Set to "tsan", "memcheck", or "drmemory" to configure the build to work 586 # Set to "tsan", "memcheck", or "drmemory" to configure the build to work
587 # with one of those tools. 587 # with one of those tools.
588 'build_for_tool%': '', 588 'build_for_tool%': '',
589 589
590 # If no directory is specified then a temporary directory will be used. 590 # If no directory is specified then a temporary directory will be used.
591 'test_isolation_outdir%': '', 591 'test_isolation_outdir%': '',
592 # True if isolate should fail if the isolate files refer to files 592 # True if isolate should fail if the isolate files refer to files
593 # that are missing. 593 # that are missing.
594 'test_isolation_fail_on_missing': 0, 594 'test_isolation_fail_on_missing': 1,
M-A Ruel 2014/09/18 17:03:20 One last thing; I'm not 100% sure it's worth keepi
jam 2014/09/18 17:05:01 well I'm not sure that all bots will succeed (i.e.
595 595
596 'wix_path%': '<(DEPTH)/third_party/wix', 596 'wix_path%': '<(DEPTH)/third_party/wix',
597 597
598 # Managed users are enabled by default. 598 # Managed users are enabled by default.
599 'enable_managed_users%': 1, 599 'enable_managed_users%': 1,
600 600
601 # Platform natively supports discardable memory. 601 # Platform natively supports discardable memory.
602 'native_discardable_memory%': 0, 602 'native_discardable_memory%': 0,
603 603
604 # Platform sends memory pressure signals natively. 604 # Platform sends memory pressure signals natively.
(...skipping 5188 matching lines...) Expand 10 before | Expand all | Expand 10 after
5793 # settings in target dicts. SYMROOT is a special case, because many other 5793 # settings in target dicts. SYMROOT is a special case, because many other
5794 # Xcode variables depend on it, including variables such as 5794 # Xcode variables depend on it, including variables such as
5795 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5795 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5796 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5796 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5797 # files to appear (when present) in the UI as actual files and not red 5797 # files to appear (when present) in the UI as actual files and not red
5798 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5798 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5799 # and therefore SYMROOT, needs to be set at the project level. 5799 # and therefore SYMROOT, needs to be set at the project level.
5800 'SYMROOT': '<(DEPTH)/xcodebuild', 5800 'SYMROOT': '<(DEPTH)/xcodebuild',
5801 }, 5801 },
5802 } 5802 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome.isolate » ('j') | chrome/chrome.isolate » ('J')

Powered by Google App Engine
This is Rietveld 408576698