build/common.gypi - Issue 575363002: Fail if an isolate entry refers to a missing file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 575363002: Fail if an isolate entry refers to a missing file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index d64dcc98f37ec9991186c6db35559e10f9fd54a2..ec101f29a8e7bf85fedcff953449b7acd139a5c1 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -591,7 +591,7 @@

'test_isolation_outdir%': '',

# True if isolate should fail if the isolate files refer to files

# that are missing.

- 'test_isolation_fail_on_missing': 0,

+ 'test_isolation_fail_on_missing': 1,

M-A Ruel 2014/09/18 17:03:20 One last thing; I'm not 100% sure it's worth keepi

jam 2014/09/18 17:05:01 well I'm not sure that all bots will succeed (i.e.

'wix_path%': '<(DEPTH)/third_party/wix',

« no previous file with comments | « no previous file | chrome/chrome.isolate » ('j') | chrome/chrome.isolate » ('J')