Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 5751002: Hook up AXVisited attribute. (Closed)

Created:
10 years ago by David Tseng
Modified:
9 years, 5 months ago
Reviewers:
Chris Guillory
CC:
dmazzoni, chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Hook up AXVisited attribute. BUG=58804 TEST=manually with VoiceOver. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68806

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
David Tseng
10 years ago (2010-12-09 21:58:03 UTC) #1
Chris Guillory
One question. LGTM http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/browser_accessibility_cocoa.mm File chrome/browser/accessibility/browser_accessibility_cocoa.mm (right): http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/browser_accessibility_cocoa.mm#newcode362 chrome/browser/accessibility/browser_accessibility_cocoa.mm:362: @"AXURL", Does this URL expect the ...
10 years ago (2010-12-09 22:04:02 UTC) #2
David Tseng
On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote: > One question. LGTM > > > http://codereview.chromium.org/5751002/diff/1/chrome/browser/accessibility/browser_accessibility_cocoa.mm > File ...
10 years ago (2010-12-09 22:16:17 UTC) #3
David Tseng
I'll try ATTR_LINK_TARGET On 12/9/10, David Tseng <dtseng@chromium.org> wrote: > On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote: ...
10 years ago (2010-12-09 22:21:25 UTC) #4
Chris Guillory
On 2010/12/09 22:21:25, David Tseng wrote: > I'll try ATTR_LINK_TARGET That looks like it should ...
10 years ago (2010-12-09 22:31:16 UTC) #5
David Tseng
Ok great. I'll make that change on a subsequent cl. On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote: ...
10 years ago (2010-12-09 23:19:10 UTC) #6
David Tseng
10 years ago (2010-12-09 23:39:06 UTC) #7
Actually, I suppose there's no harm in including the differentiation
for ATTR_LINK_TARGET now; I've updated the patch.

On 12/9/10, David Tseng <dtseng@chromium.org> wrote:
> Ok great.  I'll make that change on a subsequent cl.
>
> On 12/9/10, ctguil@chromium.org <ctguil@chromium.org> wrote:
>> On 2010/12/09 22:21:25, David Tseng wrote:
>>> I'll try ATTR_LINK_TARGET
>> That looks like it should be the right attribute but it looks like it
>> isn't set
>> in webaccessibility.cc. Should be a simple fix to get that set correctly.
>>
>> http://codereview.chromium.org/5751002/
>>
>

Powered by Google App Engine
This is Rietveld 408576698