Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/accessibility/browser_accessibility_cocoa.mm

Issue 5751002: Hook up AXVisited attribute. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/accessibility/browser_accessibility_cocoa.mm
===================================================================
--- chrome/browser/accessibility/browser_accessibility_cocoa.mm (revision 68483)
+++ chrome/browser/accessibility/browser_accessibility_cocoa.mm (working copy)
@@ -244,20 +244,24 @@
return [NSNumber numberWithBool:
!GetState(browserAccessibility_, WebAccessibility::STATE_UNAVAILABLE)];
}
+ if ([attribute isEqualToString:@"AXVisited"]) {
+ return [NSNumber numberWithBool:
+ GetState(browserAccessibility_, WebAccessibility::STATE_TRAVERSED)];
+ }
// AXWebArea attributes.
if ([attribute isEqualToString:@"AXLoaded"])
return [NSNumber numberWithBool:YES];
if ([attribute isEqualToString:@"AXURL"]) {
+ WebAccessibility::Attribute urlAttribute =
+ [[self role] isEqualToString:@"AXWebArea"] ?
+ WebAccessibility::ATTR_DOC_URL :
+ WebAccessibility::ATTR_LINK_TARGET;
return NSStringForWebAccessibilityAttribute(
browserAccessibility_->attributes(),
- WebAccessibility::ATTR_DOC_URL);
+ urlAttribute);
}
- // TODO(dtseng): provide complete implementations for the following.
- if ([attribute isEqualToString:@"AXVisited"])
- return [NSNumber numberWithBool:NO];
-
// Text related attributes.
if ([attribute isEqualToString:
NSAccessibilityNumberOfCharactersAttribute]) {
@@ -359,14 +363,14 @@
NSAccessibilityTopLevelUIElementAttribute,
NSAccessibilityValueAttribute,
NSAccessibilityWindowAttribute,
+ @"AXURL",
+ @"AXVisited",
nil]];
// Specific role attributes.
if ([self role] == @"AXWebArea") {
[ret addObjectsFromArray:[NSArray arrayWithObjects:
@"AXLoaded",
- @"AXURL",
- @"AXVisited",
nil]];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698