Remove 'alphabetic' value from text-underline-position

Source/core/css/CSSParser-in.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 2164 matching lines @@
         return parseTextDecoration(propId, important);
 
     case CSSPropertyTextDecorationStyle:
         // solid | double | dotted | dashed | wavy
         if (RuntimeEnabledFeatures::css3TextDecorationsEnabled()
             && (id == CSSValueSolid || id == CSSValueDouble || id == CSSValueDotted || id == CSSValueDashed || id == CSSValueWavy))
             validPrimitive = true;
         break;
 
     case CSSPropertyTextUnderlinePosition:
-        // auto | alphabetic | under
+        // FIXME: Implement support for 'left' and 'right' values.

[Julien - ping for review, 2013/11/04 16:06:43]

This FIXME is too far from the implementation and will likely be forgotten as we
update the code.

[abinader, 2013/11/04 16:38:02]

OK, will remove that.

+        // auto | under | inherit
         if (RuntimeEnabledFeatures::css3TextDecorationsEnabled())
             return parseTextUnderlinePosition(important);
         return false;
 
     case CSSPropertyZoom:          // normal | reset | document | <number> | <percentage> | inherit
         if (id == CSSValueNormal || id == CSSValueReset || id == CSSValueDocument)
             validPrimitive = true;
         else
             validPrimitive = (!id && validUnit(value, FNumber | FPercent | FNonNeg, HTMLStandardMode));
         break;
@@ skipping 6931 matching lines @@
     if (list->length() && (isValid || inShorthand())) {
         addTextDecorationProperty(propId, list.release(), important);
         return true;
     }
 
     return false;
 }
 
 bool CSSParser::parseTextUnderlinePosition(bool important)
 {
-    // The text-underline-position property has sintax "auto | alphabetic | [ under || [ left | right ] ]".
-    // However, values 'left' and 'right' are not implemented yet, so we will parse sintax
-    // "auto | alphabetic | under" for now.

[Julien - ping for review, 2013/11/04 16:06:43]

I would rather keep this comment so that we know what's missing in this
function.

[abinader, 2013/11/04 16:38:02]

Ack!

+    // FIXME: Implement support for 'left' and 'right' values.
     CSSParserValue* value = m_valueList->current();
     switch (value->id) {
     case CSSValueAuto:
-    case CSSValueAlphabetic:
     case CSSValueUnder:
         if (m_valueList->next())
             return false;
         addProperty(CSSPropertyTextUnderlinePosition, cssValuePool().createIdentifierValue(value->id), important);
         return true;
     default:
         return false;
     }
 }
 
@@ skipping 2799 matching lines @@
 {
     // The tokenizer checks for the construct of an+b.
     // However, since the {ident} rule precedes the {nth} rule, some of those
     // tokens are identified as string literal. Furthermore we need to accept
     // "odd" and "even" which does not match to an+b.
     return equalIgnoringCase(token, "odd") || equalIgnoringCase(token, "even")
         || equalIgnoringCase(token, "n") || equalIgnoringCase(token, "-n");
 }
 
 }